Clarify that the license key in pyprojcet.toml should only be set if it is consistent across all distribution files
#1908
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if it is consistent across all distribution files This change is approved at https://discuss.python.org/t/split-from-pep-639-expressing-project-vs-distribution-licenses-post-pep-639-mod-titled/90314/179 .
|
The link failure is due to hashicorp.com claiming we are hitting them too hard. |
befeleme
approved these changes
Sep 11, 2025
rgommers
suggested changes
Sep 12, 2025
There was a problem hiding this comment.
This use of "distribution files" seems fairly unclear to me. The key issue to clarify is that license can be specified if wheels built directly from source/sdist with a build frontend (e.g., with python -m build) must have a uniform license expression. However, wheels uploaded to PyPI or other index servers cannot be assumed to have uniform licenses, because they may not have been built by a frontend but further post-processed by a tool like auditwheel, which may change the license.
"distribution files" gives the wrong impression here (to me at least) that it applies to all wheels for a version on an index server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is approved at https://discuss.python.org/t/split-from-pep-639-expressing-project-vs-distribution-licenses-post-pep-639-mod-titled/90314/179 .
📚 Documentation preview 📚: https://python-packaging-user-guide--1908.org.readthedocs.build/en/1908/