-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Implement --uploaded-prior-to
#13625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
61fa50c to
716ee0d
Compare
|
Okay, this is again ready for review or approval, though I appreciate if no one will have time before 25.3, I will move to 26.0 if it remains unmerged before release. |
716ee0d to
255fe19
Compare
…-time`, pass to `SubprocessBuildEnvironmentInstaller`
255fe19 to
38e3992
Compare
38e3992 to
1f6c9b8
Compare
bb36ae7 to
69a8544
Compare
|
UPDATE: Of course I looked at Also following my #13674 - any chances relative specification can be used in either of those (if it turns out that they are in fact different?) The |
|
For the sake of review, I'd much prefer if relative times were added as a follow-up. This PR is already unwieldy to review as-is, adding one more feature will make that worse. |
|
Yes, we will keep discussions about a relative option strictly in #13674, there are many UX questions that need to be answered and it would potentially be a very large PR, it would be much better to land this first and then it can be considered whether to build on top of it for a relative option, as the two intended use cases are quite different. @potiuk the difference between |
|
Make perfect sense to be follow up. Thanks for explanation @notatallshaw - yeah the exclusive vs. inclusive is something not obvious from the first glance. |
Closes #6257
Supplants #12717 & #13520 (because I accidentally broke that PR)
Design Choices:
Option Name & Semantics - "uploaded-prior-to" was chosen to match semantically with an exclusive upper bound in both the "date" and "datetime" format, e.g.
--uploaded-prior-to 2025-01-01includes only packages uploaded prior to2025-01-01 00:00:00(i.e., 2024 and earlier): #13520 (comment)Timezone - Accepts ISO 8601 datetime strings, defaults to local timezone if unspecified. Documentation recommends explicit UTC (Z suffix) or UTC offset for reproducibility: #13520 (comment)
Error Handling - Fails immediately if a package index doesn't provide upload-time metadata. File system packages (local directories, wheels, etc.) are unaffected - this only applies to remote indexes: #13520 (comment), so you can specify local packages that depend on remote packages and filter those remote packages by upload time.