Merged
Conversation
DimitriPapadopoulos
force-pushed
the
UP
branch
2 times, most recently
from
56007e2 to
4be82c1
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
4be82c1 to
9881d14
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
9881d14 to
a26bbeb
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
a26bbeb to
1b101f3
Compare
miketheman
requested changes
Feb 8, 2026
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
A lot of these changes are not compliant with the minimum supported version of Python
Contributor
Author
That would be surprising, Ruff automatically takes into account the minimum supported version of Python: readme_renderer/pyproject.toml Line 36 in d184e41 The CI errors might have been caused by a human error. Let me have a look. |
UP006 Use `dict` instead of `Dict` for type annotation UP006 Use `list` instead of `List` for type annotation UP006 Use `set` instead of `Set` for type annotation
UP035 Import from `collections.abc` instead: `Callable` UP035 Import from `re` instead: `Match`
DimitriPapadopoulos
force-pushed
the
UP
branch
from
1b101f3 to
74c715f
Compare
Contributor
Author
|
Indeed a rebase error. Fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would suggest testing with ruff in addition to, or instead of flake8. This prepares such a change.
Requires #328 and #332 to pass CI tests.