Apply ruff (RUF) and tryceratops (TRY) rules#336
Merged
miketheman merged 2 commits intopypa:mainfrom Apr 10, 2026
Merged
Conversation
DimitriPapadopoulos
force-pushed
the
RUF_TRY
branch
from
eb3e964 to
a9eb257
Compare
zercao012-source
approved these changes
Apr 8, 2026
miketheman
requested changes
Apr 10, 2026
Comment on lines
+88
to
+89
| else: | ||
| return cleaned |
Member
There was a problem hiding this comment.
I think that if we're going to move it, let's remove the else return cleaned as the final operation, unless there's a reason to keep it?
RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
TRY300 Consider moving this statement to an `else` block
DimitriPapadopoulos
force-pushed
the
RUF_TRY
branch
from
a9eb257 to
d9b0ea5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would suggest testing with ruff in addition to, or instead of flake8. This prepares such a change.