BUG: fix a bug where calling distutils.build_ext.finalize_options more than once would raise an exception
#5083
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
from
cea9987 to
f95a3cb
Compare
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
from
f95a3cb to
472d8fb
Compare
neutrinoceros
commented
Sep 14, 2025
| if self.undef: | ||
| self.undef = self.undef.split(',') | ||
|
|
||
| if self.swig_opts is None: |
There was a problem hiding this comment.
In case the bug isn't obvious: this if/else fork originally assumed that self.swig_opts could be either None or str, but it immediately binds it to a list, so it fails on the second pass with AttributeError: list has no attribute 'split'.
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
from
472d8fb to
b3d1e54
Compare
2 tasks
neutrinoceros
changed the title
distutils.build_ext.finalize_options
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
from
4005da7 to
6c72bfb
Compare
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
from
6c72bfb to
e3857b0
Compare
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
2 times, most recently
from
bb76220 to
6f8cada
Compare
neutrinoceros
changed the title
distutils.build_ext.finalize_optionsdistutils.build_ext.finalize_options
2 tasks
…ore than once would raise an exception
neutrinoceros
force-pushed
the
enh/build-ext-finalize-options-idempotency
branch
from
6f8cada to
4595b98
Compare
neutrinoceros
changed the title
distutils.build_ext.finalize_optionsdistutils.build_ext.finalize_options more than once would raise an exception
|
this evolved into 2 separate bug fixes, so I split the second one out into #5084 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This allows
build_ext.finalize_optionsto be called more than once without crashing. This is helpful in h5py and yt where we cannot really finalize options of this class before needing side effects (which live in therunmethod, as recommended).I'm opening as a draft and without a test for now because I'm running out of time but I'll make sure to add one before opening for review.
Pull Request Checklist
newsfragments/.(See documentation for details)