Hotfix mf6intfac#61
Merged
jtwhite79 merged 26 commits intopypest:developfrom Apr 12, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mwtoews
reviewed
Apr 12, 2026
|
|
||
| - name: Run tests | ||
| run: uv run pytest -v | ||
| run: uv run pytest -v -s --log-cli-level=DEBUG --timeout=300 |
Collaborator
There was a problem hiding this comment.
Very nice to see a full trace via --log-cli-level=DEBUG.
I now see, however, some potential issues in the CI test log:
tests/test_notebooks.py::test_notebooks[pypestutils_pstfrom_quadtree_mf6.ipynb]
pestpp-ies: a GLM iterative ensemble smoother
...
MODFLOW runs in SEQUENTIAL mode
Run start date and time (yyyy/mm/dd hh:mm:ss): 2026/04/09 21:07:39
Writing simulation list file: mfsim.lst
Using Simulation name file: mfsim.nam
Solving: Stress period: 1 Time step: 1
Solving: Stress period: 2 Time step: 1
PACKAGE (1_GWF-SFR_0-(639)-inflow) CAUSED CONVERGENCE FAILURE
Solving: Stress period: 3 Time step: 1
PACKAGE (1_GWF-SFR_0-(639)-inflow) CAUSED CONVERGENCE FAILURE
Solving: Stress period: 4 Time step: 1
PACKAGE (1_GWF-SFR_0-(639)-inflow) CAUSED CONVERGENCE FAILURE
...
I checked with an older version, and the convergence failures are not new. Just now visible. We might want to revise this at some point later.
mwtoews
reviewed
Apr 12, 2026
mwtoews
reviewed
Apr 12, 2026
mwtoews
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix in mf6 interpolation factor calcs, fixes in the CI testing