oidc: add expiry key to mint_token response #18238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows clients that do TP exchanges to keep track of the short-lived token's expiry without poking through the macaroon's caveats.
sigmavirus24
approved these changes
Jun 8, 2025
sigmavirus24
reviewed
Jun 8, 2025
sigmavirus24
suggested changes
Jun 8, 2025
sigmavirus24
approved these changes
Jun 8, 2025
facutuesca
approved these changes
Jun 23, 2025
miketheman
requested changes
Jul 11, 2025
facutuesca
reviewed
Jul 11, 2025
Co-authored-by: Facundo Tuesca <facu@tuesca.com>
sigmavirus24
approved these changes
Jul 12, 2025
miketheman
approved these changes
Jul 14, 2025
|
@woodruffw Branch needs an update, and then I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients that do TP exchanges to keep
track of the short-lived token's expiry without
poking through the macaroon's caveats.
Closes #18235.