Add Finitary funsor for representing lazy op application#423
Merged
Conversation
eb8680
force-pushed
the
singledispatch-find-domain
branch
2 times, most recently
from
a99c429 to
538fdb8
Compare
eb8680
force-pushed
the
finitary-funsor
branch
from
e92cbef to
f23d7f8
Compare
eb8680
force-pushed
the
finitary-funsor
branch
from
8bac5ae to
89e7abb
Compare
21 tasks
eb8680
commented
Jan 20, 2021
4 tasks
fritzo
approved these changes
Feb 23, 2021
Member
fritzo
left a comment
fritzo
left a comment
There was a problem hiding this comment.
This is a great simplification!
Only one nit on keeping the standard np.einsum interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #351.
Blocked by #421, #422.This PR adds a new term
funsor.terms.Finitarythat represents lazy op application, and refactorsfunsor.terms.Einsuminto a new opEinsumOpthat makes use of thefind_domainextensibility added in #422.Tested:
Einsumtests