spool add global config for configuration of hardcoded spool quadtree params #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Any comments @miili regarding the concept of that? I just rebased. I experience it now fairly often-also with others that it is necessary to have finer Quadtrees... |
miili
requested changes
Dec 22, 2022
Member
miili
left a comment
miili
left a comment
There was a problem hiding this comment.
Thanks for rebasing this PR. Can you please remove all the dead code. I think we can get away with a very simplistic config.
Comment on lines
+55
to
+58
| class ConfigBase(Object): | ||
| @classmethod | ||
| def default(cls): | ||
| return cls() |
Member
There was a problem hiding this comment.
Not needed imo. Implement in KiteConfig
Comment on lines
+84
to
+85
| x = op.expanduser(op.expandvars(x)) | ||
| return x |
Member
There was a problem hiding this comment.
Suggested change
| x = op.expanduser(op.expandvars(x)) | |
| return x | |
| return op.expanduser(op.expandvars(x)) |
|
|
||
| kite_dir_tmpl = os.environ.get( | ||
| 'KITE_DIR', | ||
| os.path.join('~', '.kite')) |
Member
There was a problem hiding this comment.
Please use pathlib.Path throughout.
Comment on lines
+32
to
+34
| class PathWithPlaceholders(String): | ||
| '''Path, possibly containing placeholders.''' | ||
| pass |
Comment on lines
+37
to
+52
| class VisibleLengthSetting(Object): | ||
| class __T(TBase): | ||
| def regularize_extra(self, val): | ||
| if isinstance(val, list): | ||
| return self.cls(key=val[0], value=val[1]) | ||
|
|
||
| return val | ||
|
|
||
| def to_save(self, val): | ||
| return (val.key, val.value) | ||
|
|
||
| def to_save_xml(self, val): | ||
| raise NotImplementedError() | ||
|
|
||
| key = String.T() | ||
| value = Float.T() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.