Skip to content

Conversation

@fe51
Copy link
Member

@fe51 fe51 commented Dec 15, 2025

TO REVIEW AFTER #531 (introducing poses)

This PR to address #524  which is part of the planned changes to the data model

It introduces the following modifications

  • Add table occlusion_masks in model
  • Add occlusion_masks schema & crud
  • Add occlusion_masks CRUD endpoint
  • Updates poses endpoints adding occlusion mask listing related to a pose
  • Update tests
  • Update db diagram

note

  • occlusion mask read endpoint is permissive endpoint on (as long as authentified on the api)

What is missing (to be discussed of to handle in another PR)

  • Alembic migrations
  • Client updates -> will be done later
  • Client tests (struggled to be properly run locally)

Happy to discuss it

@github-actions github-actions bot added topic: docs Improvements or additions to documentation endpoint: cameras labels Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 95.12195% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (ac3e175) to head (2d7aa51).

Files with missing lines Patch % Lines
src/app/api/api_v1/endpoints/occlusion_masks.py 95.83% 2 Missing ⚠️
src/app/api/api_v1/endpoints/poses.py 86.66% 2 Missing ⚠️
src/app/api/dependencies.py 88.88% 1 Missing ⚠️
src/app/crud/crud_occlusion_mask.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   83.99%   84.81%   +0.82%     
==========================================
  Files          42       45       +3     
  Lines        1318     1409      +91     
==========================================
+ Hits         1107     1195      +88     
- Misses        211      214       +3     
Flag Coverage Δ
backend 84.89% <95.12%> (+0.88%) ⬆️
client 83.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

{
"id": 3,
"pose_id": 2,
"mask": "(1,0.1,0.9,0.9,0.5)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be a good idea to test with more than one mask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants