fix: GitHub Pages deployment - base path and CSS class attributes#5
Merged
pyros-projects merged 2 commits intomainfrom Nov 24, 2025
Merged
fix: GitHub Pages deployment - base path and CSS class attributes#5pyros-projects merged 2 commits intomainfrom
pyros-projects merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Critical Fix for GitHub Pages Deployment
Fixes two issues preventing the documentation site from rendering correctly on GitHub Pages.
🔍 Problems
1. Missing Base Path (Primary Issue)
Symptom: All assets (CSS, JS, images) returning 404 errors on GitHub Pages
Root Cause: Astro wasn't configured with the correct base path for GitHub Pages subdirectory deployment
Assets were trying to load from:
https://pyros-projects.github.io/_astro/index.cssShould load from:
https://pyros-projects.github.io/wishful/_astro/index.css2. JSX vs HTML Syntax (Secondary Issue)
Symptom: Custom CSS classes not applied in production builds
Root Cause: Using
className(JSX/React) instead ofclass(HTML) in MDX files🔧 Changes
Modified Files
docs-site/astro.config.mjsWhy: Configures Astro to prepend
/wishful/to all asset URLs for proper GitHub Pages routingdocs-site/src/content/docs/index.mdxChanged all
className="..."toclass="..."(12 replacements)Why: Astro/Starlight expects standard HTML attributes in production builds
pyproject.toml✅ Result
Before
After
/wishful/_astro/...theme.css🧪 Verification
Used Playwright to identify 404 errors and path mismatches.
🎯 Impact
Ready to merge and deploy! 🚀