Open
Conversation
lukasjarosch
requested review from
metalmatze,
rlex and
sebastiangaiser
as code owners
Collaborator
|
Hey, thank you for your PR. We will revisit this once the initial release using this repository is done. |
Exposes the `--config-map-mode` cli flag via the chart. If the mode is enabled, additional roles for ConfigMaps are added as well in order to allow pyrra to interact with then.
lukasjarosch
force-pushed
the
feat/configmap-mode
branch
from
761bb36 to
95098e3
Compare
Collaborator
|
Hey, I think the chart is finally ready to go. Can you please rebase your PR as we released 0.16.0 |
Collaborator
|
@lukasjarosch are you still planning to implement this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
config-map-modecli flag via the values including the required ClusterRole modifications.Motivation
We use cortex to read PrometheusRules via ConfigMaps. Pyrra itself does support that, but the helm chart does not (yet).