Ensure burn rate factors are accurate, and add exhaustion label#775
Ensure burn rate factors are accurate, and add exhaustion label#775saswatamcode wants to merge 4 commits intopyrra-dev:mainfrom
exhaustion label#775Conversation
… SLO windows Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
metalmatze
left a comment
There was a problem hiding this comment.
Super cool! Thanks.
Especially adding more tests all over the place! 👍
I'm still not 100% sure about the exhaustion label, since the budget might be gone way quicker depending on the current budget that's left and the potentially uneven amount of events happening over time. For now, let's see how it goes with that label.
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
|
Long time no see. |
|
Hey @saswatamcode, long time! Are you still interested in getting this merged? The burn rate factor corrections and the additional tests looked good. If so, could you either rebase this PR onto current |
|
Hey! Sorry this dropped off my radar. Let me try to update these this week! |
This PR does the following,
Windows()function from14, 7, 2, 1to14, 5.6, 2.8, 1to more accurately represent 28 day burn rate in the following cases (as per conversation offline with @metalmatze),Windowswhich describe its functionality for posterity.exhaustionlabel to all budget burn alerts, which represents time till the error budget is fully exhausted.Test_windowsto account for various common SLO windows like90d, 84d, 30d, 28d, 14d & 7dMost of this large diff is to account for changes in tests. Let me know what you think! 🙂