Open
Conversation
Author
|
Hey we talked over slack, I might be missing some of the kubebuild part and i didnt manage to build the image to check over COPY dist dist but i think this is a good shot at it. |
Member
|
Sorry for the long silence. I just need to time to properly test this on a Kubernetes cluster and make sure it works as expected. |
Member
|
Hey @ItayReshef, are you still interested in getting this in? I'd like to test this on a cluster and see how it works. Note that there are merge conflicts that would need resolving, and newer versions of controller-runtime use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.