Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 70.96% 71.03% +0.06%
==========================================
Files 64 64
Lines 4881 4892 +11
==========================================
+ Hits 3464 3475 +11
Misses 1417 1417 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR updates development dependencies and performs a set of small clean-ups and behavioural refinements across the core snapshot/ICCS code paths, CLI helpers, and documentation, with added integration coverage for snapshots and notes.
Changes:
- Bump multiple dependencies in
uv.lock(includingruff,pytest-mpl,textual, andpysmo). - Improve snapshot/ICCS/sync behaviour and robustness (e.g., build ICCS from snapshot parameters, safer quality sync assumptions).
- Expand integration tests and refresh CLI/TUI/docs wording to match current behaviour.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Dependency lock updates. |
tests/integration/models/test_note.py |
Adds integration coverage for core note read/write helpers. |
tests/integration/core/test_snapshots.py |
Adds a tie-breaker test for sync_from_matching_hash snapshot selection. |
tests/integration/core/test_iccs.py |
Adds coverage for building ICCS from snapshot (event + seismogram parameters). |
src/aimbat/utils/_uuid.py |
Simplifies UUID shortener loop logic around hyphen boundaries. |
src/aimbat/models/_readers.py |
Fixes station name formatting when network is empty/None. |
src/aimbat/models/_parameters.py |
Expands docstring for seismogram-parameter base model. |
src/aimbat/core/_snapshot.py |
Logging/message tweaks; replaces an assertion with a runtime check + exception; clarifies docstrings. |
src/aimbat/core/_project.py |
Logging tweaks; improves delete flow; increases last_modified timestamp resolution in triggers. |
src/aimbat/core/_iccs.py |
Clarifies MCCC quality write semantics; loads snapshot seismogram parameters; improves logging; documents commit side effect. |
src/aimbat/core/_event.py |
Improves boolean filtering and logging punctuation; clarifies event quality docstring. |
src/aimbat/core/_data.py |
Adds warning for mismatched event metadata on time match; improves error handling for missing IDs/unsupported creation. |
src/aimbat/_tui/help/tab-snapshots.md |
Clarifies what snapshot event parameters represent. |
src/aimbat/_tui/help/tab-seismograms.md |
Updates description of Stack CC recalculation timing. |
src/aimbat/_tui/help/tab-project.md |
Clarifies when/why ICCS may fail to build and how to troubleshoot. |
src/aimbat/_cli/tool.py |
Updates min-CC picking help text to reflect scroll-based interaction. |
src/aimbat/_cli/snapshot.py |
Expands rollback docstring; snapshot dump/list behaviour aligns with docs. |
src/aimbat/_cli/common/_parameters.py |
Adds handling for non-zero editor exit codes (but currently inconsistent with stated behaviour). |
docs/usage/snapshots.md |
Updates snapshot CLI usage examples and terminology (e.g., all, min_cc). |
|
|
||
| logger.warning( | ||
| f"Editor '{editor}' exited with code {result.returncode}; discarding changes." | ||
| ) |
There was a problem hiding this comment.
open_in_editor() logs that it is "discarding changes" when the editor exits non-zero, but it still reads and returns the temporary file content. This means changes are not actually discarded (and the warning is misleading). If the intent is to discard, return initial_content (or skip reading the file) when returncode != 0; otherwise adjust the warning text to reflect that the file is still read.
| ) | |
| ) | |
| return initial_content |
📚 Documentation preview 📚: https://aimbat--234.org.readthedocs.build/en/234/