-
Notifications
You must be signed in to change notification settings - Fork 162
Revert pinning of build-time dependencies #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seifertm
wants to merge
14
commits into
pytest-dev:main
Choose a base branch
from
seifertm:revert-build-dependency-pinning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e6a0a37
build: Revert pinning of build-time dependencing due to issues with d…
seifertm 851bc56
build: Unify constraints files.
seifertm ba1eacf
build: Updated minimum required tox version to v4.28.
seifertm f282d1c
build: Use tox "constraints" and "deps" configuration options rather …
seifertm f26d16b
build: Install wheel instead of sdist into tox environments.
seifertm 762c7e4
build: Pin setuptools and setuptools-scm versions during tox build.
seifertm 35e4fc3
build: Remove unnecessary deps specification in tox.ini
seifertm 95dc263
build: Removed obsolete requirements.txt files
seifertm 21891bd
build: Move constraints file to project root.
seifertm db910a0
build: Use tox to build both sdist and wheel files.
seifertm 93a04a1
build: Move building and checking of distribution files into dedicate…
seifertm fdaa29f
ci: Split lint job into separate jobs for building and linting.
seifertm ed1e13a
build: Add constraints for dependency check-wheel-contents.
seifertm a8d3b70
build: Add constraints for dependency twine.
seifertm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Bump the minimum required version of tox to v4.28. This change is only relevant if you use the ``tox.ini`` file provided by pytest-asyncio to run tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
alabaster==0.7.16 | ||
annotated-types-0.7.0 | ||
attrs==25.3.0 | ||
babel==2.17.0 | ||
backports.asyncio.runner==1.2.0 | ||
backports.tarfile==1.2.0 | ||
certifi==2025.8.3 | ||
charset-normalizer==3.4.3 | ||
check-wheel-contents==0.6.1 | ||
cffi==1.17.1 | ||
click==8.1.8 | ||
coverage==7.10.4 | ||
cryptography==45.0.6 | ||
docutils==0.21.2 | ||
exceptiongroup==1.3.0 | ||
hypothesis==6.138.2 | ||
iniconfig==2.1.0 | ||
id==1.5.0 | ||
idna==3.10 | ||
imagesize==1.4.1 | ||
importlib_metadata==8.7.0 | ||
iniconfig==2.1.0 | ||
jaraco.classes==3.4.0 | ||
jaraco.context==6.0.1 | ||
jaraco.functools==4.3.0 | ||
jeepney==0.9.0 | ||
Jinja2==3.1.6 | ||
keyring==25.6.0 | ||
markdown-it-py==3.0.0 | ||
MarkupSafe==3.0.2 | ||
mdurl==0.1.2 | ||
more-itertools==10.7.0 | ||
nh3==0.3.0 | ||
packaging==25.0 | ||
pluggy==1.6.0 | ||
Pygments==2.19.2 | ||
pycparser==2.22 | ||
pydantic==2.11.7 | ||
pydantic-core==2.33.2 | ||
pytest==8.4.1 | ||
readme-renderer==44.0 | ||
requests==2.32.4 | ||
requests-toolbelt==1.0.0 | ||
rfc3986==2.0.0 | ||
rich==14.1.0 | ||
SecretStorage==3.3.3 | ||
setuptools==80.9.0 | ||
setuptools-scm==8.3.0 | ||
snowballstemmer==3.0.1 | ||
sortedcontainers==2.4.0 | ||
Sphinx==8.0.2 | ||
sphinx-rtd-theme==3.0.2 | ||
sphinxcontrib-applehelp==2.0.0 | ||
sphinxcontrib-devhelp==2.0.0 | ||
sphinxcontrib-htmlhelp==2.1.0 | ||
sphinxcontrib-jquery==4.1 | ||
sphinxcontrib-jsmath==1.0.1 | ||
sphinxcontrib-qthelp==2.0.0 | ||
sphinxcontrib-serializinghtml==2.0.0 | ||
tomli==2.2.1 | ||
twine==6.1.0 | ||
typing_extensions==4.14.1 | ||
typing-inspection==0.4.1 | ||
urllib3==2.5.0 | ||
wheel-filename==1.4.2 | ||
zipp==3.23.0 |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it's usually nice to make the specs sparse.
And it's be a good idea to specify in a code comment which features of the deps require those minimum versions to keep track of why they are set and help judge if it's okay to bump them in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't traced how the minimum versions got in place, but I understand the idea. We should add a comment when bumping the minimum versions in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that I applied your changes and it immediately got reformatted to the old status by pre-commit CI running pyproject-fmt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pyproject-fmt doesn't seem to have a configuration option to change the formatting of dependencies, so I suggest we just go with that. Or do you feel strongly about the spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they improve readability and so I use this style in PyPUG. Many "opinionated" tools promote weird opinions so I avoid them. For human-readable content, it's important, for generated things (like pip-tools output) less so.