Skip to content

ESRF tune example proposal#161

Merged
simoneliuzzo merged 10 commits intomainfrom
esrf_tune_example_proposal
Jan 30, 2026
Merged

ESRF tune example proposal#161
simoneliuzzo merged 10 commits intomainfrom
esrf_tune_example_proposal

Conversation

@simoneliuzzo
Copy link
Copy Markdown
Contributor

@simoneliuzzo simoneliuzzo commented Jan 30, 2026

This is just a proposal

I have removed the path management part to make the reading lighter and more immediate.

I have also introduced a switch flag to show the MML feature restored and imporved (can access all time any model)

The test however is not running due to an error:

pyaml.common.exception.PyAMLException: Tune tuning tool TUNE not defined

@JeanLucPons
Copy link
Copy Markdown
Contributor

Try:

repalce:

sr.live.get_tune_tuning("TUNE")

by

sr.live.tune

I think it was renamed to DEFAULT_TUNE_CORRECTION so it map to the tune property now.

@simoneliuzzo
Copy link
Copy Markdown
Contributor Author

Ruff check is still failing... No idea why

@simoneliuzzo simoneliuzzo changed the title WIP: Esrf tune example proposal Esrf tune example proposal Jan 30, 2026
@simoneliuzzo simoneliuzzo changed the title Esrf tune example proposal ESRF tune example proposal Jan 30, 2026
@JeanLucPons
Copy link
Copy Markdown
Contributor

Ruff check is still failing... No idea why

This morning i wrote this simple ORM server in ~30min and fight with ruff during 1h !
I had to play with some git add pff...

@simoneliuzzo
Copy link
Copy Markdown
Contributor Author

simoneliuzzo commented Jan 30, 2026

@JeanLucPons

I have added the dummy CS in the readme.

Then, to fix the Ruff issue

pre-commit uninstall
precommit install
git commit ... -m
(ruff failed, but fixed)
git commit ... -m
ruff all ok

@JeanLucPons
Copy link
Copy Markdown
Contributor

thanks
Is ok to merge for you ?

JeanLucPons
JeanLucPons previously approved these changes Jan 30, 2026
@simoneliuzzo
Copy link
Copy Markdown
Contributor Author

@JeanLucPons
yes, I have added a few more lines in the readme.
We will fix them if needed.

@JeanLucPons JeanLucPons self-requested a review January 30, 2026 09:31
@simoneliuzzo simoneliuzzo merged commit 0db6874 into main Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants