Merged
Conversation
gubaidulinvadim
previously approved these changes
Nov 18, 2025
Contributor
gubaidulinvadim
left a comment
There was a problem hiding this comment.
For me, this is good. It passes all the tests. The only thing I do not understand is if we have a fast c-loader, what is the point of having a slow loader (and the slow one being the default option)?
Contributor
Author
As mentioned in the doc, the slow loader prevents to get the line number informations. Using Fast loader: Using slow loader: A possible hack for this is to use by default the fast loader and if an errors occurs then reparse using the slow loader. |
gubaidulinvadim
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to use fast yaml loader: