Access the correct variables in BPMHScalarAggregator and BPMVScalarAggregators#81
Merged
JeanLucPons merged 4 commits intomainfrom Nov 20, 2025
Merged
Access the correct variables in BPMHScalarAggregator and BPMVScalarAggregators#81JeanLucPons merged 4 commits intomainfrom
JeanLucPons merged 4 commits intomainfrom
Conversation
…gregator. Their names are mangled, as is done when inheriting a private variable
Contributor
|
I agree that it is not very user friendly and that it is not supposed to happen. I would suggest to either use a |
Contributor
Author
|
I moved them to public namespace and added test. This is ready for final review and merge @JeanLucPons . |
JeanLucPons
approved these changes
Nov 20, 2025
Contributor
JeanLucPons
left a comment
JeanLucPons
left a comment
There was a problem hiding this comment.
Nice work Kostas !
Thanks.
We will have to discuss soon about your Interface, your get_many() and your config file ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because they are inheriting a private variable, their names are mangled. It is ugly to access the variables like this. I would like advice how you think we could do this better.
Changes:
handvproperties.__latticeand__refptsofBPMScalarAggregatorto public namespace.BPMHScalarAggregator,BPMVScalarAggregatoras they were doing the opposite.Solves #80 .