Fix for empty array

[JeanLucPons]

This PR allows empty arrays to be created.

ex:

sr = Accelerator.load(config_path)
element_holder = sr.design

vst = Magnet(MagnetArrayConfigModel(name="NoV",elements=[]))
vst.fill_array(element_holder) # Attach the array

However pre-commit is true nigthmare for me, i got unexpected behaviors.
I need to learn.....

[ubuntu20acu.pons] > git commit -m "Fix for empty array" -a
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing pyaml/arrays/bpm_array.py

fix end of files.........................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Failed

A second execution worked !

[ubuntu20acu.pons] > git commit -m "Fix for empty array" -a
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Passed
[fix-for-empty-array 5f82541] Fix for empty array
 3 files changed, 11 insertions(+), 10 deletions(-)

[gubaidulinvadim]

@JeanLucPons , with how I set up the pre-commit this is normal behaviour. You try to commit once, if there are any errors they are fixed automatically. But you need to commit a second time to apply the changes. That's how we have the formatting set up at SOLEIL for our codes also.

[gubaidulinvadim]

I think adding a simple test with creation of an empty array will be useful.

[JeanLucPons]

OK, so we have to know that it works like that.
An other trap, by default pre-commit is not enabled.
As i reset my repo due to too many conflicts, i rerun pre-commit run --allfiles and this time it seems ok.

[gubaidulinvadim]

@JeanLucPons , you need to run pre-commit install to enable it. I'm not aware of any way to make it available by default to all collaborators. I think in the hooks part of .git is not tracked and the philosophy is that everyone can configure their own hooks.

[JeanLucPons]

OK.
PR can be blocked by one single person who asking for a change ?

[gubaidulinvadim]

For me something was broken. Because new commits were pushed after I've asked for inclusion of tests. After this the review should not block anything.

[JeanLucPons]

For me something was broken. Because new commits were pushed after I've asked for inclusion of tests. After this the review should not block anything.

OK, that can be annoying if someone ask for a change and take one month of holidays :D