Skip to content

Move most of setuptools attributes to pyproject.toml #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrbean-bremen wants to merge 1 commit into
base: master
Choose a base branch
from
+64 −69
Open

Move most of setuptools attributes to pyproject.toml #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
3.3.1 (unreleased)
==================

- Nothing changed yet.
- Make sure that the `License-Expression` attribute is correctly set
in the metadata.


3.3.0 (2025-12-04)
Expand Down
63 changes: 62 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,66 @@
[build-system]
build-backend = "setuptools.build_meta"
requires = [
"setuptools >= 40.8.0"
"setuptools >= 77.0.3"
]

[project]
name = "greenlet"
description = "Lightweight in-process concurrent programming"
readme = "README.rst"
authors = [
{ name = "Alexey Borzenkov", email = "snaury@gmail.com" },
]
maintainers = [
{ name = "Jason Madden", email = "jason@seecoresoftware.com" }
]
license = "MIT AND Python-2.0"
license-files = [
'LICENSE',
'LICENSE.PSF',
]
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"Natural Language :: English",
"Programming Language :: C",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Operating System :: OS Independent",
"Topic :: Software Development :: Libraries :: Python Modules",
]
keywords = [
"greenlet",
"coroutine",
"concurrency",
"threads",
"cooperative",
]
requires-python = ">=3.10"
dynamic = ["version"]

[project.urls]
Homepage = "https://github.com/python-greenlet/greenlet"
Documentation = "https://greenlet.readthedocs.io"
Repository = "https://github.com/python-greenlet/greenlet"
Issues = "https://github.com/python-greenlet/greenlet/issues"
Changelog = "https://greenlet.readthedocs.io/en/latest/changes.html"

[project.optional-dependencies]
docs = [
"Sphinx",
"furo",
]
test = [
"objgraph",
"psutil",
"setuptools",
]

[tool.setuptools.dynamic]
version = {attr = "greenlet.__version__"}
67 changes: 0 additions & 67 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,6 @@
# this:
cpp_compile_args.append('/std:c++20')

def readfile(filename):
with open(filename, 'r') as f: # pylint:disable=unspecified-encoding
return f.read()

GREENLET_SRC_DIR = 'src/greenlet/'
GREENLET_HEADER_DIR = GREENLET_SRC_DIR
GREENLET_HEADER = GREENLET_HEADER_DIR + 'greenlet.h'
Expand Down Expand Up @@ -197,72 +193,9 @@ def _find_impl_headers():
]


def get_greenlet_version():
with open('src/greenlet/__init__.py') as f: # pylint:disable=unspecified-encoding
looking_for = '__version__ = \''
for line in f:
if line.startswith(looking_for):
version = line[len(looking_for):-2]
return version
raise ValueError("Unable to find version")


setup(
name="greenlet",
version=get_greenlet_version(),
description='Lightweight in-process concurrent programming',
long_description=readfile("README.rst"),
long_description_content_type="text/x-rst",
url="https://greenlet.readthedocs.io/",
keywords="greenlet coroutine concurrency threads cooperative",
author="Alexey Borzenkov",
author_email="snaury@gmail.com",
maintainer='Jason Madden',
maintainer_email='jason@seecoresoftware.com',
project_urls={
'Bug Tracker': 'https://github.com/python-greenlet/greenlet/issues',
'Source Code': 'https://github.com/python-greenlet/greenlet/',
'Documentation': 'https://greenlet.readthedocs.io/',
'Changes': 'https://greenlet.readthedocs.io/en/latest/changes.html',
},
license="MIT AND Python-2.0",
license_files=[
'LICENSE',
'LICENSE.PSF',
],
platforms=['any'],
package_dir={'': 'src'},
packages=find_packages('src'),
Comment on lines 234 to 235
Copy link
Author

@mrbean-bremen mrbean-bremen Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are strictly speaking not needed, but removing them broke the version test, as the output of setup.py --version contained a few lines related to auto-discovery of src-layout.

include_package_data=True,
headers=headers,
ext_modules=ext_modules,
classifiers=[
"Development Status :: 5 - Production/Stable",
'Intended Audience :: Developers',
'Natural Language :: English',
'Programming Language :: C',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Programming Language :: Python :: 3.13',
'Programming Language :: Python :: 3.14',
'Operating System :: OS Independent',
'Topic :: Software Development :: Libraries :: Python Modules'
],
extras_require={
'docs': [
'Sphinx',
'furo',
],
'test': [
'objgraph',
'psutil',
'setuptools',
],
},
python_requires=">=3.10",
zip_safe=False,
)