Parent bindings should not affect multibind bindings #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidparsson
force-pushed
the
multibind-scope-tweaks
branch
2 times, most recently
from
91b596b to
b9fa7b3
Compare
This is more in line with how regular bindings work.
davidparsson
force-pushed
the
multibind-scope-tweaks
branch
from
b9fa7b3 to
bd8f001
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 96.52% 96.51% -0.02%
==========================================
Files 1 1
Lines 605 602 -3
Branches 104 103 -1
==========================================
- Hits 584 581 -3
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidparsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The previous functionality has never been released, so it's not a breaking change.
Also a bunch of more tests are added.