Fix exception in NetworkManagerSettings.get_connections_by_id

[hkhateb]

Previously, calling get_connections_by_id could raise the following exception:

    settings_paths = await nm_settings.get_connections_by_id("eth0")
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../networkmanager/objects.py", line 177, in get_connections_by_id
    settings_properties = await settings.get_settings()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../dbus_proxy_async_method.py", line 108, in _dbus_async_call
    reply_message = await bus.call_async(call_message)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
sdbus.dbus_exceptions.DbusServiceUnknownError: The name org.freedesktop.NetworkManager was not provided by any .service files

This exception was discovered with the following test code:

import asyncio
from sdbus import sd_bus_open_system
from sdbus_async.networkmanager import NetworkManagerSettings

async def test_get_connections_by_id():
    system_bus = sd_bus_open_system()
    nm_settings = NetworkManagerSettings(system_bus)
    settings_paths = await nm_settings.get_connections_by_id("eth0")
    print(settings_paths)

if __name__ == "__main__":
    asyncio.run(test_get_connections_by_id())

After this fix, the issue is resolved and get_connections_by_id works correctly without raising an exception.

[igo95862]

Hello @hkhateb

Thank you for submitting this PR.

Could I ask you to add some changes?

First, please name the commit something like Fix NetworkManagerSettings.get_connections_by_id not using the bus it was initialized with. The Fix exception is very generic and does not tell what exactly was fixed. Also change the description explaining the existing bug where the get_connections_by_id does not work properly with explicitly passed bus.

[hkhateb]

Hello @igo95862 I changed the title and the description as you asked

[igo95862]

Thank you!

[hkhateb]

you are welcome

…

On Sat, Aug 23, 2025 at 3:50 PM igo95862 ***@***.***> wrote: *igo95862* left a comment (python-sdbus/python-sdbus-networkmanager#77) <#77 (comment)> Thank you! — Reply to this email directly, view it on GitHub <#77 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADEPZGN3T4SBNW2WFISRMLL3PBPSXAVCNFSM6AAAAACERIQGUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJWHEZTKMBWGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>