Skip to content

gh-76007: pydoc: Catch DeprecationWarning for stdlib module __version__ attributes #139997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-76007: pydoc: Catch DeprecationWarning for stdlib module __version__ attributes #139997

wants to merge 8 commits into from
+65 −18

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Oct 12, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 12, 2025
Open
picnixz
picnixz reviewed Oct 12, 2025
View reviewed changes
picnixz
picnixz reviewed Oct 12, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests for that? (to see that we indeed don't catch the warning)

picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
picnixz
picnixz approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll let Adam have a look to see if he wants something different as well.

@StanFromIreland
Copy link
Member Author

Renaming MyModule to TestModule? ;-)

picnixz
picnixz reviewed Oct 13, 2025
View reviewed changes
@StanFromIreland StanFromIreland mentioned this pull request Oct 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @picnixz