-
-
Notifications
You must be signed in to change notification settings - Fork 869
Document type-refactor
#1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Document type-refactor
#1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be worth expanding a bit more on what is considered "internal code refactoring". E.g. are any behavior changes admitted, if not user-facing? Are refactoring of user-facing functions, without changes in behavior included?
I made an issue for this, I hadn't seen this PR. Feel free to link to it in the title. |
No worries, we don't usually link issues in titles here anyway. |
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm by no means a devguide expert. @hugovk, would you like to review?
📚 Documentation preview 📚: https://cpython-devguide--1588.org.readthedocs.build/