[mypyc] feat: __mypyc_empty_tuple__ constant
#19654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In 3.13 and later, we could use |
BobTheBuidler
force-pushed
the
empty-tuple-constant
branch
2 times, most recently
from
02cd112 to
fecc89c
Compare
BobTheBuidler
commented
Aug 25, 2025
|
|
||
| static inline PyObject *_CPyTuple_LoadEmptyTupleConstant() { | ||
| // do tests still pass if I comment this out? empty tuple singleton is not tracked by gc | ||
| // Py_INCREF(__mypyc_empty_tuple__); |
There was a problem hiding this comment.
I believe I can take out this Py_INCREF since the empty tuple singleton is not tracked by the GC but I want to wait for confirmation before I get rid of the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that any time a user has a kwarg-only call expression like
fn(abc=123, ...)in their compiled code, andfuncis not a native function, a new empty tuple is created every timeThis is not really necessary, we can just hold the same empty tuple in memory as a constant and pass it around. It's immutable, and that's already what we're already doing, since
tuple() is tuple()but our current method involves more steps.This should slightly improve the speed of kwarg-only python func calling.