Add type annotations for **options in tkinter.messagebox functions

[GameRoMan]

Add explicit **options: Any to all tkinter.messagebox functions to remove "partially unknown type" warnings from type checkers like Pyright and Pylance

[Akuli]

Thanks. This is not quite right; it would be better to add individually all options that these functions accept and their types.

For example, like this:

def showinfo(
    title: str | None = None,
    message: str | None = None,
    *,
    detail: str = ...,
    icon: Literal["error", "info", "question", "warning"] = ...,
    parent: tkinter.Misc = ...,
) -> str: ...

To figure out what options exist, you can pass an invalid option and look at the error message. Try tkinter.messagebox.showinfo(asdf="") for example.

To figure out what each option does, you can try it, or look at the manual here: https://www.tcl-lang.org/man/tcl8.6/TkCmd/messageBox.htm

Let me know if anything is unclear. Tkinter stubs are more difficult than you'd expect :) Also, if this is more work than you want to do, you can just close this PR and wait for someone else (probably me) to do it.

[GameRoMan]

Alright, I’ll check it out

[Akuli]

This is much better! A couple things could still be improved.

[Akuli]

In IDE autocompletions and such, seeing _Icon is less helpful than Literal["error", "info", "question", "warning"]. I'd suggest just copy/pasting these Literals to all the places that use them instead of type aliases.

An advantage of copy/pasting the Literals is that you can make them function-specific. For example, specifying default="retry" doesn't make sense if the dialog only has "yes" and "no" buttons, so the default parameter of askyesno() should be Literal["yes", "no"].

There are many existing type aliases in tkinter. For most of them, I would accept PRs that delete them.

[Akuli]

Even though the type parameter works at runtime, I don't think including it in the stubs makes sense. If you call showinfo(), the type you want is obviously "info" and type checkers should complain if you specify anything else.

I'd suggest deleting all type: _Type parameters.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉