Make copy.replace
more strongly typed
#14819
Open
+16
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current stub for
copy.replace
accepts arbitrary keyword arguments. We can useParamSpec
to link the signature ofobj.__replace__
to the supplied keyword arguments.This allows passing positional arguments to
copy.replace
, but I think it's fine, given that__replace__
isn't supposed to contain positional arguments in the signature anyway (docs forobject.__replace__
)Demo of the proposed stub for
copy.replace
in the pyright playground: