Fix TypedDict qualifier inheritance with same name #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #677 +/- ##
==========================================
+ Coverage 97.36% 97.38% +0.01%
==========================================
Files 3 3
Lines 7680 7716 +36
==========================================
+ Hits 7478 7514 +36
Misses 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This should also fix #308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered through CPython 3.14 test_typing.py: https://github.com/JanEricNitschke/typing_extensions/actions/runs/17619859892/job/50062609198#step:7:44
Tests and code are directly taken from CPython 3.14.
Tests: https://github.com/python/cpython/blob/3.14/Lib/test/test_typing.py#L8616
Code: https://github.com/python/cpython/blob/3.14/Lib/typing.py#L3139
Except that i omitted the raising of the
TypeErrorwhen overwriting a mutable key with a read-only key pending further discussion.