Raise LookupError in partition_all when length is invalid
#603
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes an iterable's `__len__` is incorrect, which can lead to bad output from `partition_all`. We now raise an exception (when we previously output bad data) in these cases so the user can more easily find the invalid iterable and fix it. Fixes pytoolz#602.
Mr0grog
force-pushed
the
602-errors-are-no-fun-but-they-are-more-fun-than-bad-data
branch
from
f9e646f to
defe68c
Compare
|
Hi, just checking back in on this! Is there anything that needs to happen to move it along? |
|
LGTM, thanks @Mr0grog! This PR behaves as I expect. I still think it's reasonable to expect Apologies for the slow review, but I really appreciate the attention to detail you put into this @Mr0grog! Thanks for helping make Merging. |
|
Also, I find the branch name of this PR amusing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes an iterable's
__len__is incorrect, which can lead to bad output frompartition_all. This change ensurespartition_allchecks for this case and raise an exception (when it previously output bad data) so the user can more easily find the invalid iterable and fix it.Fixes #602. /cc @eriknw