-
Notifications
You must be signed in to change notification settings - Fork 377
Add support for MXFP8 All gather #3435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3435
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 7 PendingAs of commit f96d168 with merge base 0975a40 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @avizon-aws! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
looks reasonable, would you mind rebasing as we've landed some refactors to MXTensor recently? just curious, which framework are you using TP + mxfp8 from? |
|
I think I already rebased just before creating the PR (yesterday night), so it should be up to date with mainline. I fixed the ruff formating to pass the workflows, I think one of the workflow was failing due to a missing tag on the PR, i think the right tag should be "add new feature", i wasnt able to add it, I think i dont have the permission for it. I tried the TP AG using native pytorch, i created a test script for it, didnt use any other framework currently. I updated the sharding strategy for to_mx due to which it required the TP AG. |
|
lgtm! will leave approval for @vkuzo who i think is also taking a look at this. @avizon-aws to fix the code analysis ci job, please run the linter with |
Currently when trying to use TP All gather with MXFP8, it gives an unimplemented error for the all gather operation. This PR adds support for MXFP8 all gather which will enable better performance as it will reduce the bandwidth required for the gather compute.