Skip to content

Conversation

@avizon-aws
Copy link

Currently when trying to use TP All gather with MXFP8, it gives an unimplemented error for the all gather operation. This PR adds support for MXFP8 all gather which will enable better performance as it will reduce the bandwidth required for the gather compute.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3435

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 7 Pending

As of commit f96d168 with merge base 0975a40 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Dec 4, 2025

Hi @avizon-aws!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@danielvegamyhre
Copy link
Contributor

cc @vkuzo @drisspg

@vkuzo
Copy link
Contributor

vkuzo commented Dec 4, 2025

looks reasonable, would you mind rebasing as we've landed some refactors to MXTensor recently?

just curious, which framework are you using TP + mxfp8 from?

@avizon-aws
Copy link
Author

I think I already rebased just before creating the PR (yesterday night), so it should be up to date with mainline. I fixed the ruff formating to pass the workflows, I think one of the workflow was failing due to a missing tag on the PR, i think the right tag should be "add new feature", i wasnt able to add it, I think i dont have the permission for it.

I tried the TP AG using native pytorch, i created a test script for it, didnt use any other framework currently. I updated the sharding strategy for to_mx due to which it required the TP AG.

@danielvegamyhre
Copy link
Contributor

danielvegamyhre commented Dec 5, 2025

lgtm! will leave approval for @vkuzo who i think is also taking a look at this.

@avizon-aws to fix the code analysis ci job, please run the linter with ruff check --fix torchao/ test/ and ruff format torchao/ test/

@danielvegamyhre danielvegamyhre added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants