Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Dec 4, 2025

Summary:

Uses the torch.float4_e2m1fn_x2 dtype in mxfp4 and nxfp4 torchao
tensors.

Requires pytorch/pytorch#169595, so we need
to wait for the next PyTorch branch cut.

Note: nvfp4 models in vllm currently hit an error
https://gist.github.com/vkuzo/e1407ee68c9ebb8d0f67478aedd81b96
before or after this PR, so some more debugging to do before
landing this.

Test Plan:

CUDA_VISIBLE_DEVICES=6 time pytest test/prototype/mx_formats/ -s

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Dec 4, 2025

Stack from ghstack (oldest at bottom):

vkuzo added a commit that referenced this pull request Dec 4, 2025
Summary:

Uses the `torch.float4_e2m1fn_x2` dtype in mxfp4 and nxfp4 torchao
tensors.

Requires pytorch/pytorch#169595, so we need
to wait for the next PyTorch branch cut.

Note: nvfp4 models in vllm currently hit an error
https://gist.github.com/vkuzo/e1407ee68c9ebb8d0f67478aedd81b96
before or after this PR, so some more debugging to do before
landing this.

Test Plan:

```
CUDA_VISIBLE_DEVICES=6 time pytest test/prototype/mx_formats/ -s
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: ee5d3a0
ghstack-comment-id: 3614417747
Pull-Request: #3440
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3440

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 869147e with merge base 534bea5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants