-
Notifications
You must be signed in to change notification settings - Fork 710
Replace tests comparing functionality to sox with hard coded results. #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samanklesaria
wants to merge
5
commits into
kaldi_mock
Choose a base branch
from
sox_mock
base: kaldi_mock
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−7
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+93.8 KB
..._unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_allpass.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...t/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_band_with_noise.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...unctional/sox_compatibility_test.py__TestFunctionalFiltering__test_band_without_noise.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...functional/sox_compatibility_test.py__TestFunctionalFiltering__test_bandpass_with_csg.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...ctional/sox_compatibility_test.py__TestFunctionalFiltering__test_bandpass_without_csg.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...ittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_bandreject.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...dio_unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_bass.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_contrast.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...ctional/sox_compatibility_test.py__TestFunctionalFiltering__test_dcshift_with_limiter.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...onal/sox_compatibility_test.py__TestFunctionalFiltering__test_dcshift_without_limiter.wav
Binary file not shown.
Binary file added
BIN
+517 KB
...o_unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_deemph.wav
Binary file not shown.
Binary file added
BIN
+1.06 MB
...o_unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_dither.wav
Binary file not shown.
Binary file added
BIN
+1.06 MB
...test/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_dither_noise.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...nittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_equalizer.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...nctional/sox_compatibility_test.py__TestFunctionalFiltering__test_flanger_sine_linear.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...functional/sox_compatibility_test.py__TestFunctionalFiltering__test_flanger_sine_quad.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...onal/sox_compatibility_test.py__TestFunctionalFiltering__test_flanger_triangle_linear.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...tional/sox_compatibility_test.py__TestFunctionalFiltering__test_flanger_triangle_quad.wav
Binary file not shown.
Binary file added
BIN
+1.06 MB
...dio_unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_gain.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_highpass.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
..._unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_lowpass.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...nittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_overdrive.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...tional/sox_compatibility_test.py__TestFunctionalFiltering__test_perf_biquad_filtering.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...ttest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_phaser_sine.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...t/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_phaser_triangle.wav
Binary file not shown.
Binary file added
BIN
+517 KB
...dio_unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_riaa.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...o_unittest/functional/sox_compatibility_test.py__TestFunctionalFiltering__test_treble.wav
Binary file not shown.
Binary file added
BIN
+517 KB
...unittest/transforms/sox_compatibility_test.py__TestFunctionalFiltering__test_fade_0_q.wav
Binary file not shown.
Binary file added
BIN
+517 KB
...unittest/transforms/sox_compatibility_test.py__TestFunctionalFiltering__test_fade_1_h.wav
Binary file not shown.
Binary file added
BIN
+517 KB
...unittest/transforms/sox_compatibility_test.py__TestFunctionalFiltering__test_fade_2_t.wav
Binary file not shown.
Binary file added
BIN
+118 KB
...ox_compatibility_test.py__TestFunctionalFiltering__test_vad_0_vad_go_stereo_44100_wav.wav
Binary file not shown.
Binary file added
BIN
+34.6 KB
.../sox_compatibility_test.py__TestFunctionalFiltering__test_vad_1_vad_go_mono_32000_wav.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...t/transforms/sox_compatibility_test.py__TestFunctionalFiltering__test_vol_0_amplitude.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...unittest/transforms/sox_compatibility_test.py__TestFunctionalFiltering__test_vol_1_db.wav
Binary file not shown.
Binary file added
BIN
+93.8 KB
...ttest/transforms/sox_compatibility_test.py__TestFunctionalFiltering__test_vol_2_power.wav
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the end state we want is for
if os.path.exists(path):
to be True, right? If it's false it means we forgot to check-in a file? If that's the case, let's not have theif
part and always dounconditionally.
I agree with your previous point that the file generation should still exist for reference, but for safety it might be best to comment it out, so that in never gets executed.
In the current state, as I understand it, if
sox
is available and the file doesn't exist for whatever reason, then we are effectively checking against sox's output instead of checking against a file which should exist - so we're not testing what we think we're testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your understanding is correct! I was planning to address your point by just removing the sox dependency from the dependencies installed on CI, so that if the file was missing we'd see an error about importing the library. But I can certainly comment the generation part out if you think that's clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be safer to do all of those: