Skip to content

Remove generic lfilter loop #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove generic lfilter loop #4023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40243c0
Remove generic lfilter loop
samanklesaria Aug 5, 2025
d923531
Add dispatcher for mac core loop
samanklesaria Sep 5, 2025
48f077a
Fix lint
pearu Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/libtorchaudio/lfilter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,27 +73,6 @@ void cpu_lfilter_core_loop(
});
}

void lfilter_core_generic_loop(
const torch::Tensor& input_signal_windows,
const torch::Tensor& a_coeff_flipped,
torch::Tensor& padded_output_waveform) {
int64_t n_samples_input = input_signal_windows.size(2);
int64_t n_order = a_coeff_flipped.size(1);
auto coeff = a_coeff_flipped.unsqueeze(2);
for (int64_t i_sample = 0; i_sample < n_samples_input; i_sample++) {
auto windowed_output_signal =
torch::narrow(padded_output_waveform, 2, i_sample, i_sample + n_order)
.transpose(0, 1);
auto o0 = torch::select(input_signal_windows, 2, i_sample) -
at::matmul(windowed_output_signal, coeff).squeeze(2).transpose(0, 1);
padded_output_waveform.index_put_(
{torch::indexing::Slice(),
torch::indexing::Slice(),
i_sample + n_order - 1},
o0);
}
}

} // namespace

TORCH_LIBRARY(torchaudio, m) {
Expand All @@ -110,7 +89,3 @@ TORCH_LIBRARY_IMPL(torchaudio, CUDA, m) {
m.impl("torchaudio::_lfilter_core_loop", &cuda_lfilter_core_loop);
}
#endif

TORCH_LIBRARY_IMPL(torchaudio, CompositeExplicitAutograd, m) {
m.impl("torchaudio::_lfilter_core_loop", &lfilter_core_generic_loop);
}
11 changes: 10 additions & 1 deletion src/torchaudio/functional/filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,8 +932,17 @@ def _lfilter_core_generic_loop(input_signal_windows: Tensor, a_coeffs_flipped: T
padded_output_waveform[:, :, i_sample + n_order - 1] = o0


def _lfilter_core_loop_dispatcher(
input_signal_windows: Tensor, a_coeffs_flipped: Tensor, padded_output_waveform: Tensor
):
if input_signal_windows.is_cuda or input_signal_windows.is_cpu:
return torch.ops.torchaudio._lfilter_core_loop(input_signal_windows, a_coeffs_flipped, padded_output_waveform)
else:
return _lfilter_core_generic_loop(input_signal_windows, a_coeffs_flipped, padded_output_waveform)


if _IS_TORCHAUDIO_EXT_AVAILABLE:
_lfilter_core_loop = torch.ops.torchaudio._lfilter_core_loop
_lfilter_core_loop = _lfilter_core_loop_dispatcher
else:
_lfilter_core_loop = _lfilter_core_generic_loop

Expand Down
Loading