Compile with CUDA 13.0 e Nvidia 5090 SM_120 #4065
Conversation
in CUDA 13 Nvidia clean duplicate function. Need to use standard function. This patch run for make a whl pip package.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4065
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @DrStone71! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -440,7 +441,7 @@ __launch_bounds__(BLOCK_SIZE) void topk_reduce_and_copy_list_per_batch_kernel( | |||
| topk_values, | |||
| beam, | |||
| items_per_batch, | |||
| cub::FpLimits<float>::Lowest(), | |||
| std::numeric_limits<float>::lowest(), | |||
There was a problem hiding this comment.
Nice, please consider:
| std::numeric_limits<float>::lowest(), | |
| ::cuda::std::numeric_limits<float>::lowest(), |
| @@ -23,6 +23,7 @@ | |||
| // OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | |||
| // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | |||
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| #include <limits> | |||
There was a problem hiding this comment.
I believe a proper header would be:
| #include <limits> | |
| #include <cuda/std/limits> |
in CUDA 13 Nvidia clean duplicate function. Need to use standard function. This patch run for make a whl pip package.
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.