Stop validating that build_variables.bzl matches buck-generated executorch_srcs.cmake #13392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
added
the
release notes: build
|
hmm, unittest-buck failure looks unrelated but I'm not sure. will retry after workflow finishes |
GregoryComer
approved these changes
Aug 15, 2025
swolchok
requested review from
JacobSzwejbka,
lucylq,
manuelcandales,
kimishpatel,
jackzhxng,
mergennachin,
digantdesai and
cccclai
as code owners
This was referenced Aug 18, 2025
|
build-documentation has been failing on PRs. test-binary-size-linux-gcc was broken on main. eval_llama-wikitext-linux looks like it was an infra flake. merging. |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…torch_srcs.cmake (pytorch#13392) The previous PR switched to build_variables.bzl as the source of truth. We can land this PR when we are happy to stop requiring Buck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR switched to build_variables.bzl as the source of truth. We can land this PR when we are happy to stop requiring Buck.