-
Notifications
You must be signed in to change notification settings - Fork 649
NXP backend: Add support for conversion of Conv1D operator #13549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP backend: Add support for conversion of Conv1D operator #13549
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13549
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit a8ffed0 with merge base bd92f1a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "module: nxp" "release notes: nxp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0d530e4
to
5182658
Compare
Yes, this is a conflict. I added fix for padding with zero-point to this PR. In our IR, Conv1D operator doesn't exist and it is emulated by changing to Conv2D and then the result is converted to Conv1D format. So this fix will change it also for Conv2D. However, the other PR is still needed as it changes Average pool. |
+ fix input_shapes type hint in to_quantized_edge_program() + add test cases for Conv1D operator + add fix for padding with zero-point
5182658
to
a8ffed0
Compare
Summary
This PR adds delegation of
aten.conv1d
to Neutron. Fixesinput_shapes
type hint into_quantized_edge_program()
. Fixesoperators_not_to_delegate
assignment in partitioner.Test plan
Unit tests provided in backends/nxp/tests/ir/converter/node_converter/test_conv_converter.py.
cc @digantdesai @JakeStevens @robert-kalmar