install headers from runtime/backend #13558
Open
+61
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
Stack from ghstack (oldest at bottom): |
swolchok
requested review from
larryliu0820,
kirklandsign,
JacobSzwejbka,
lucylq,
manuelcandales,
cccclai,
jackzhxng,
shoumikhin and
digantdesai
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13558
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Cancelled JobsAs of commit 2b5e2b6 with merge base 335de46 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This was referenced Aug 20, 2025
| @@ -480,6 +480,13 @@ add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/configurations) | |||
|
|
|||
| # Install `executorch` library as well as `executorch-config.cmake` under | |||
| # ${CMAKE_INSTALL_PREFIX}/ | |||
| install( | |||
There was a problem hiding this comment.
why do we need one for basically every runtime subdir as opposed to just one runtime/?
There was a problem hiding this comment.
I wanted to keep the exclude patterns narrowly scoped.
JacobSzwejbka
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like these are all public and we simply missed installing them.