Skip to content

Summary: Add MCU model verification to CI #13572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −0
Open

Summary: Add MCU model verification to CI #13572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,3 +940,42 @@ jobs:
build-mode: Release
build-tool: cmake
docker-image: ci-image:executorch-ubuntu-22.04-clang12

test-mcu-models:
name: test-mcu-models
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
strategy:
matrix:
include:
- build-tool: cmake
fail-fast: false
permissions:
id-token: write
contents: read
with:
runner: linux.2xlarge
docker-image: ci-image:executorch-ubuntu-22.04-arm-sdk
submodules: 'recursive'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 90
script: |
BUILD_TOOL=${{ matrix.build-tool }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support anything else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we do, I was copy pasting this from other jobs. I will clean this up in the follow up pr

# The generic Linux job chooses to use base env, not the one setup by the image
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
conda activate "${CONDA_ENV}"
# Try to mirror these as closely as possible
source .ci/scripts/utils.sh
install_executorch "--use-pt-pinned-commit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need "--use-pt-pinned-commit"?

Copy link
Contributor Author

@psiddh psiddh Aug 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need "--use-pt-pinned-commit"?

No I don't think this is needed
[EDIT] Looks like this is needed, When I removed it, the CI job was failing

.ci/scripts/setup-arm-baremetal-tools.sh
source examples/arm/ethos-u-scratch/setup_path.sh
# Run selective Build
chmod +x examples/selective_build/test_selective_build.sh
examples/selective_build/test_selective_build.sh "${BUILD_TOOL}"
# Run MCU models
chmod +x examples/arm/run_mcu_models_fvp.sh
examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to have ethos targets for this script? just take cortex-m55, cortex-m85?

Copy link
Contributor Author

@psiddh psiddh Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this involves changing build_executor_runner.sh script (which the newly added 'run_mcu_models_fvp.sh' relies on). In the build_executor_runner.sh, it has something like this

if [[ ${target} == "ethos-u55" ]]; then
target_cpu=cortex-m55
else
target_cpu=cortex-m85
fi

Loading