Skip to content

Call .detach() in static attention cache update helper #13618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2025
Merged

Call .detach() in static attention cache update helper #13618

merged 1 commit into from
Aug 23, 2025

Conversation

sxu
Copy link
Contributor

@sxu sxu commented Aug 22, 2025

Summary: This reduces memory usage.

Differential Revision: D80853817

@sxu @facebook-github-bot
Call .detach() in static attention cache update helper
a77980c 
Summary: This reduces memory usage.

Differential Revision: D80853817
@sxu sxu requested review from lucylq and jackzhxng as code owners August 22, 2025 22:32
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13618

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a77980c with merge base 3bb42ec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80853817

@sxu sxu requested a review from billmguo August 22, 2025 22:32
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu sxu requested a review from limintang August 22, 2025 22:33
@facebook-github-bot facebook-github-bot merged commit bb05705 into pytorch:main Aug 23, 2025
105 of 109 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@sxu @agrima1304
Call .detach() in static attention cache update helper
3bb031b 
Differential Revision: D80853817

Pull Request resolved: pytorch#13618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limintang limintang limintang approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@billmguo billmguo Awaiting requested review from billmguo

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxu @facebook-github-bot @limintang