Skip to content

Conversation

trivedivivek
Copy link
Contributor

Summary:

Summary

This diff improves the overall performance of the linear shader by removing manual unrolling in the linear_qcsnw_tiled.glsl file.

The changes include:

  • Removing the [[unroll]] directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance.
  • Changing the type of mat1 from VEC4_T[TILE_ROWS] to T[TILE_ROWS][4] to better match the access pattern in the loop.

Differential Revision: D84571616

Summary:
### Summary

This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. 

The changes include:
- Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance.
- Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop.

Differential Revision: D84571616
@trivedivivek trivedivivek requested a review from SS-JIA as a code owner October 14, 2025 15:13
Copy link

pytorch-bot bot commented Oct 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15110

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 9c3d279 with merge base 45336ce (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
Copy link

meta-codesync bot commented Oct 14, 2025

@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84571616.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

trivedivivek added a commit to trivedivivek/executorch that referenced this pull request Oct 14, 2025
…e. (pytorch#15110)

Summary:

### Summary

This diff improves the overall performance of the linear shader by removing manual unrolling in the `linear_qcsnw_tiled.glsl` file. 

The changes include:
- Removing the `[[unroll]]` directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance.
- Changing the type of `mat1` from `VEC4_T[TILE_ROWS]` to `T[TILE_ROWS][4]` to better match the access pattern in the loop.

Differential Revision: D84571616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant