Removing manual unroll in linear shader to improve overall performance. #15110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
This diff improves the overall performance of the linear shader by removing manual unrolling in the
linear_qcsnw_tiled.glsl
file.The changes include:
[[unroll]]
directive in the for loop to allow the compiler to automatically unroll the loop, which can lead to better performance.mat1
fromVEC4_T[TILE_ROWS]
toT[TILE_ROWS][4]
to better match the access pattern in the loop.Differential Revision: D84571616