[AIU Profiler] Allow AIU profiling via env vars on newer PyTorch versions#1172
Open
mcalman wants to merge 2 commits intopytorch:mainfrom
Open
[AIU Profiler] Allow AIU profiling via env vars on newer PyTorch versions#1172mcalman wants to merge 2 commits intopytorch:mainfrom
mcalman wants to merge 2 commits intopytorch:mainfrom
Conversation
Signed-off-by: Max Calman <maxcalman1@gmail.com>
Contributor
Author
|
@divyanshk thanks for the review! I have resolved the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where setting the environment variable
ProfilerActivity=PrivateUse1wouldn't enable the PrivateUse1 activities for AIU as intended.This is because
ActivityType::PRIVATEUSE1_RUNTIMEandActivityType::PRIVATEUSE1_DRIVERare enabled by default when passingtorch.profiler.ProfilerActivity.CPUtotorch.profiler.profileon newer versions of PyTorch (see: here).