-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix #3186 - create leaf/non-leaf/requires_grad/retain_grad tutorial #3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3492
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
14255e0
to
e2e0d01
Compare
cc: @soulitzer |
e2e0d01
to
3c181eb
Compare
Preview looks pretty good - make sure to add into a toctree since it'll be an orphan otherwise. @soulitzer - do you mind taking a look? |
3c181eb
to
8bac8c8
Compare
25d2fbc
to
2771ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, just got back from PTO.
This looks good to me, thanks for the great work!
df02633
to
3e24aee
Compare
…orial This was originally bundled with PR pytorch#3389, but now broken into two separate tutorials after discussing with PyTorch team.
3e24aee
to
8c1d9bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you so much and sorry for the delay in reviewing.
No worries! I know everyone is super busy :) |
The only suggestion for improvement (can be a separate PR) is to have diagrams to be in mermaid format so they are supported in both dark and light mode. |
This was originally bundled with PR #3389, but now broken into two separate tutorials after discussing with PyTorch team.
Fixes #3186
Description
Add a tutorial which goes over the subtleties of leaf, non-leaf, and
requires_grad
vs.retain_grad
Link to preview is here (wait for docs to build it):
Checklist