Add destructor for XLAGraphExecutor to free resource #9636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a destructor for
XLAGraphExecutor
, to trigger the destructor of PJRT classExecutable
/LoadedExecutable
. This helps to do some special works (e.g. clear disk) when the PJRT program is over.Backgroud
The PJRT plugins may want to do some special operations when the
Executable
/LoadedExecutable
is destructed, but in Torch-XLA, theExecutable
/LoadedExecutable
will never be destructed since a raw pointercomputation_cache_
has stored these objects and is never released:computation_cache_
is created inCreateComputationCache()
Executable
/LoadedExecutable
is added tocomputation_cache_
in https://github.com/pytorch/xla/blob/master/torch_xla/csrc/xla_graph_executor.cpp#L1595XLAGraphExecutor
is used as a global static instance and will never clear or delete this pointerDetail
Add a destructor for
XLAGraphExecutor
, to clear and delete this raw pointer.