Skip to content

fix: check vehicle extended capabilities for climate controls#256

Open
iamer wants to merge 1 commit intopytoyoda:mainfrom
iamer:main
Open

fix: check vehicle extended capabilities for climate controls#256
iamer wants to merge 1 commit intopytoyoda:mainfrom
iamer:main

Conversation

@iamer
Copy link
Copy Markdown
Contributor

@iamer iamer commented Mar 9, 2026

It seems PHEVs and EVs advertise climate ability in the vehicle's extended capabilities as "econnect_climate_capable" so check that in addition to "climate_capable".

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the climate control capability detection for Toyota vehicles, specifically addressing an issue where PHEVs and EVs were not correctly identified as having climate control due to their unique way of advertising this feature. By checking for an additional capability flag, the system can now accurately determine climate control availability across a broader range of vehicles.

Highlights

  • Climate Control Capability Detection: Modified the _vehicle_has_climate_capability function to check for econnect_climate_capable in the vehicle's extended capabilities, in addition to climate_capable, to correctly identify climate control support for PHEVs and EVs.
Changelog
  • custom_components/toyota/climate.py
    • Updated the logic for determining if a vehicle has climate control capabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly extends the vehicle capability check for climate control to include econnect_climate_capable, which is necessary for PHEVs and EVs. The logic is sound. I've added one suggestion to improve the code's readability and maintainability by avoiding a repeated function call.

Comment thread custom_components/toyota/climate.py Outdated
It seems PHEVs and EVs advertise climate ability in the vehicle's
extended capabilities as "econnect_climate_capable" so check that
in addition to "climate_capable".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant