Skip to content

Conversation

@mraspaud
Copy link
Member

@mraspaud mraspaud commented Jun 2, 2025

This PR returns gcp distances for the caller to have a measure of improvement.

  • Closes #xxxx
  • Tests added
  • Fully documented

@mraspaud mraspaud self-assigned this Jun 2, 2025
@mraspaud
Copy link
Member Author

mraspaud commented Jun 2, 2025

I'm realising this might no be the cleanest solution, we should probably return the distances instead.
Fixed

@mraspaud mraspaud marked this pull request as draft June 2, 2025 13:54
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.58%. Comparing base (9159f20) to head (0a7ede2).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pyorbital/geoloc_avhrr.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   89.49%   89.58%   +0.09%     
==========================================
  Files          17       17              
  Lines        2750     2784      +34     
==========================================
+ Hits         2461     2494      +33     
- Misses        289      290       +1     
Flag Coverage Δ
unittests 89.58% <97.56%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mraspaud mraspaud changed the title Add a threshold for the minimization to fail Return distances from GCP minimization Jun 2, 2025
@mraspaud mraspaud marked this pull request as ready for review June 5, 2025 13:13
@coveralls
Copy link

coveralls commented Jun 5, 2025

Coverage Status

coverage: 89.543% (+0.09%) from 89.451%
when pulling 0a7ede2 on mraspaud:add-threshold-for-minimization
into 795c002 on pytroll:main.

@mraspaud mraspaud merged commit 66e1970 into pytroll:main Jun 9, 2025
18 checks passed
@mraspaud mraspaud deleted the add-threshold-for-minimization branch June 9, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants