Skip to content

Conversation

@seapyth0n
Copy link
Contributor

https://www.n2yo.com/database/?name=KINEIS#results

Added platforms to support the Kineis constellation.

25 new IDs were added.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.35%. Comparing base (45cb9d1) to head (875e479).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          19       19           
  Lines        3027     3027           
=======================================
  Hits         2735     2735           
  Misses        292      292           
Flag Coverage Δ
unittests 90.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Oct 9, 2025

Coverage Status

coverage: 90.315%. remained the same
when pulling 875e479 on seapyth0n:main
into 0d11a75 on pytroll:main.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. One thing I think github is trying to make me aware of is that it looks like your entries are separated by tabs instead of spaces like the other entries in this file. This may not be an issue, but what do you think about changing it for consistency?

@seapyth0n seapyth0n marked this pull request as draft October 20, 2025 23:14
@seapyth0n
Copy link
Contributor Author

Good catch on the spacing. I updated that in the latest commit, but the codecov is still at 90.35%?

@seapyth0n seapyth0n marked this pull request as ready for review October 20, 2025 23:26
@djhoese
Copy link
Member

djhoese commented Oct 21, 2025

Code coverage only checks code files (.py) not a .txt file like the platforms file. No worries.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mraspaud any problems with this?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 8918a16 into pytroll:main Oct 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants