-
Notifications
You must be signed in to change notification settings - Fork 79
Extended platform support for Kineis Constellation #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Extended support for new Kineis satellites
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 19 19
Lines 3027 3027
=======================================
Hits 2735 2735
Misses 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djhoese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough. One thing I think github is trying to make me aware of is that it looks like your entries are separated by tabs instead of spaces like the other entries in this file. This may not be an issue, but what do you think about changing it for consistency?
fix spacing tab-->single space
|
Good catch on the spacing. I updated that in the latest commit, but the codecov is still at 90.35%? |
|
Code coverage only checks code files (.py) not a .txt file like the platforms file. No worries. |
djhoese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mraspaud any problems with this?
mraspaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://www.n2yo.com/database/?name=KINEIS#results
Added platforms to support the Kineis constellation.
25 new IDs were added.