Skip to content

Conversation

@pnuu
Copy link
Member

@pnuu pnuu commented Nov 18, 2025

The TLE writing didn't add a linechange character after the last TLE entry it writes to a text file causing problems in certain 3rd party software. This PR adds the linechange.

Also, couple of unrelated docstrings were clarified.

  • Tests updated

@pnuu pnuu requested review from adybbroe and mraspaud November 18, 2025 12:17
@pnuu pnuu self-assigned this Nov 18, 2025
@pnuu pnuu added the bug label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (b55ac29) to head (9ec69e6).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   90.45%   90.46%           
=======================================
  Files          19       19           
  Lines        3039     3040    +1     
=======================================
+ Hits         2749     2750    +1     
  Misses        290      290           
Flag Coverage Δ
unittests 90.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pnuu pnuu mentioned this pull request Nov 18, 2025
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 82040eb into pytroll:main Nov 18, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants