Open
Conversation
pnuu
requested changes
Sep 10, 2024
Member
pnuu
left a comment
There was a problem hiding this comment.
Could you add some unit tests for the new feature? Also add documentation for the new plugin to doc/source/plugins.rst.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 95.78% 95.43% -0.35%
==========================================
Files 12 12
Lines 2989 3001 +12
==========================================
+ Hits 2863 2864 +1
- Misses 126 137 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An addition for using the scene.crop() functionality from
satpyhas been added totrollflow2. It can be called in thetrollflow2.yamlfile with- fun: !!python/name:trollflow2.plugins.crop. This functionality was implemented because I was tasked with cropping geostationary data and saving it to the local archive. The aim of this approach was to preserve the data in its original form while reducing overall storage space by retaining only the data over the region of interest.The
crop()function was added, which uses the same outputjob["resampled_scenes"]as `resample(), so they cannot be used simultaneously. However, no situations have been identified where using both functions at the same time would be necessary.flake8 trollflow2AUTHORS.mdif not there already