Skip to content

Comments

Support python 3.14#244

Merged
mraspaud merged 3 commits intopytroll:mainfrom
mraspaud:py314
Feb 2, 2026
Merged

Support python 3.14#244
mraspaud merged 3 commits intopytroll:mainfrom
mraspaud:py314

Conversation

@mraspaud
Copy link
Member

With new handling of multiprocessing and forking, python 3.14 broke a few things in trollflow2.

This PR fixes it.

  • Tests passed

@mraspaud mraspaud self-assigned this Jan 20, 2026
@mraspaud mraspaud requested a review from pnuu as a code owner January 20, 2026 11:15
@mraspaud mraspaud added the bug Something isn't working label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.70%. Comparing base (bec2e28) to head (fd65f83).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
trollflow2/tests/test_launcher.py 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   94.52%   94.70%   +0.18%     
==========================================
  Files          15       15              
  Lines        3379     3383       +4     
==========================================
+ Hits         3194     3204      +10     
+ Misses        185      179       -6     
Flag Coverage Δ
unittests 94.70% <91.89%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

So the Manager didn't work when it was a global varible, and the cache usage fixes it?

@mraspaud
Copy link
Member Author

mraspaud commented Feb 2, 2026

LGTM.

So the Manager didn't work when it was a global varible, and the cache usage fixes it?

Yes, that's correct, in python >= 3.14, the process spawning method changed, so the memory context isn't shared at all between processes anymore. I older version we could provoke the error too if we change the default spawning method to "forkserver" (which is now the default).

@mraspaud mraspaud merged commit ddcc614 into pytroll:main Feb 2, 2026
9 of 10 checks passed
@mraspaud mraspaud deleted the py314 branch February 2, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants